Closes #8873: Remove the outdated dist subproject #8916
Conversation
1. Removes the `dist` subproject as it was unused in the main and had bitrotted to an unworking state. This was preventing a successful `sbt update`, and hence import into some IDEs. 2. Renames the working `dist-bootstrapped` project to `dist` as the latter no longer exists. 3. Adds some clarifications to the documentation on testing about which tests are run when running `test` vs. `dotty-bootstrapped/test`. Close scala#8873 Review by @smarter
iamrecursion
force-pushed
the
wip/ara/fix-build
branch
from
abc0703 to
124273a
Compare
|
Ah, I missed those! Should all be gone now. I can't find a single reference to |
|
Do you have any idea why CI is failing on this? I can't see how the failures would be at all related to the changes I've made, but there may be some understanding I'm lacking! |
|
Very weird, looking at the log I think that there was a race condition between github and github actions! https://github.com/lampepfl/dotty/pull/8916/checks?check_run_id=656794529 says it's running on commit 124273a but the actual logs mention commit 22fe7f6 which does not include the latest changes you did, so I guess the action was triggered before github updated the commit this PR points to. I've restarted the job to see if that helps. |
|
Looks like that fixed it! |
|
Brilliant, thank you! |
This problem is caused by a recent change in Dotty: scala/scala3#8916 Luckily, it does not impact the test result. Only the PowerMacro tests use `compile` to precompile code, and precompiling is not part of the benchmarks.
distsubproject as it was unused in the main and hadbitrotted to an unworking state. This was preventing a successful
sbt update, and hence import into some IDEs.dist-bootstrappedproject todistas thelatter no longer exists.
which tests are run when running
testvs.dotty-bootstrapped/test.Closes #8873
Review by @smarter